Re: [PATCH net] sfc: Fix error code in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Solarflare linux maintainers <linux-net-drivers@xxxxxxxxxxxxxx>
Subject: Re: [PATCH net] sfc: Fix error code in probe
From: Edward Cree <ecree@xxxxxxxxxxxxxx>
Date: Mon, 21 Sep 2020 12:09:00 +0100
Cc: Martin Habets <mhabets@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <20200918143311.GD909725@mwanda>
References: <20200918143311.GD909725@mwanda>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 18/09/2020 15:33, Dan Carpenter wrote:
> This failure path should return a negative error code but it currently
> returns success.
>
> Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Edward Cree <ecree@xxxxxxxxxxxxxx>
Thanks for catching this.

References:
- [PATCH net] sfc: Fix error code in probe
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] lib/scatterlist: Fix memory leak in sgl_alloc_order()
Next by Date: [PATCH] hwmon: (w83627ehf) Fix a resource leak in probe
Previous by thread: [PATCH net] sfc: Fix error code in probe
Next by thread: Re: [PATCH net] sfc: Fix error code in probe
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux