On 9/18/20 11:13 AM, Joe Perches wrote: > On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote: >> On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote: >>> Remove the superfluous break, as there is a 'return' before it. >>> >> >> Apparently, the change is correct. Please, just add a proper Fixes tag by >> yourself this time. > > There's no need for a "Fixes:" here, it's purely cosmetic. > > btw: > > There are at least 150 instances of > return foo(...); > break; > still in the kernel tree: A lot of these are false positives, since they follow a pattern of: if (some_condition) return func(); break; -- Jens Axboe
