Re: [Cocci] [RFC PATCH] scripts: coccicheck: Improve error feedback when coccicheck fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 14 Sep 2020, Markus Elfring wrote:

> …
> > +++ b/scripts/coccicheck
> > @@ -126,8 +126,14 @@ run_cmd_parmap() {
> >  	if [ $VERBOSE -ne 0 ] ; then
> >  		echo "Running ($NPROC in parallel): $@"
> >  	fi
> > -	echo $@ >>$DEBUG_FILE
> > -	$@ 2>>$DEBUG_FILE
> > +	if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> …
>
> How do you think about to use the following check variant?
>
> +	if [ "${DEBUG_FILE}" != '/dev/null' -a "${DEBUG_FILE}" != '' ]; then

What difference does it make?

julia

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux