Hi Colin,
Colin King <colin.king@xxxxxxxxxxxxx> wrote on Fri, 11 Sep 2020
11:23:21 +0100:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Pointer eb is being assigned a value that is never read, the assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/mtd/mtdswap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
> index 58eefa43af14..795dec4483c2 100644
> --- a/drivers/mtd/mtdswap.c
> +++ b/drivers/mtd/mtdswap.c
> @@ -1053,7 +1053,6 @@ static int mtdswap_writesect(struct mtd_blktrans_dev *dev,
> if (ret < 0)
> return ret;
>
> - eb = d->eb_data + (newblock / d->pages_per_eblk);
> d->page_data[page] = newblock;
>
> return 0;
Yes it looks unused but perhaps it helps to catch the logic here. This
is not a strong disagreement but I'd keep it this way. Let's see what
other maintainers think.
Thanks,
Miquèl
