On Mon, 7 Sep 2020, Markus Elfring wrote: > >>>>>> +@replacement depends on patch@ > >>>>>> +expression base, device1, device2, index, private, resource; > >>>>>> +@@ > >>>>>> +( > >>>>>> +-resource = platform_get_resource(device1, IORESOURCE_MEM, index); > >>>>>> + base = > >>>>>> +- devm_ioremap_resource > >>>>>> ++ devm_platform_get_and_ioremap_resource > >>>>>> + ( > >>>>>> +- & > >>>>>> + device1 > >>>>>> +- ->dev > >>>>>> + , > >>>>>> +- resource > >>>>>> ++ index, &resource > >>>>>> + ); > >>>>>> +| > >>>>>> +-private->res = platform_get_resource(device1, IORESOURCE_MEM, index); > >>>>>> + base = > >>>>>> +- devm_ioremap_resource > >>>>>> ++ devm_platform_get_and_ioremap_resource > >>>>>> + (device2, > … > >> Both source code change patterns from these branches of a SmPL disjunction > >> work as I would expect it by the current Coccinelle software. > >> Would you like to clarify any remaining related open issues? > > > > In one case the first argument of devm_ioremap_resource has to be changed > > to produce the first argument of devm_platform_get_and_ioremap_resource > > and in the other case there is no such change. "work as I would expect" > > is not a proper explanation of why this is correct. > > Would like to achieve that a SmPL script (like the one which I present here) > can help to adjust the implementation of the functions “mvebu_sei_probe” > and “hi655x_pmic_probe” (for example) for the desired reuse of the wrapper > function “devm_platform_get_and_ioremap_resource”? > > > > Maybe you can point to some previous commits that have made the change in this way. I looked at some of the provided examples, but none of them leaves the first argument of devm_ioremap_resource unchanged. julia > > Not yet for these source code examples. > > Some patches were contributed. > https://lore.kernel.org/patchwork/project/lkml/list/?q=devm_platform_get_and_ioremap_resource&archive=both&state=* > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep&q=devm_platform_get_and_ioremap_resource > > Regards, > Markus >
