Re: [PATCH][next] xsk: fix incorrect memory allocation failure check on dma_map->dma_pages

Daniel Borkmann <daniel@xxxxxxxxxxxxx> · Wed, 2 Sep 2020 20:35:24 +0200

On 9/2/20 6:13 PM, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The failed memory allocation check for dma_map->dma_pages is incorrect,
it is null checking dma_map and not dma_map->dma_pages. Fix this.

Addresses-Coverity: ("Logicall dead code")
Fixes: 921b68692abb ("xsk: Enable sharing of dma mappings")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks, already applied a fix that was sent earlier [0].

  [0] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=1d6fd78a213ee3874f46bdce083b7a41d208886d