Hello,
Colin King <colin.king@xxxxxxxxxxxxx> wrote on Tue, 14 Jul 2020
20:00:03 +0100:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently there are two places where the return status in ret is being
> checked for an error however the assignment of ret has been omitted
> making the checks redundant. Fix this by adding in the missing assignments
> of ret.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
> index 63f967902c2d..b45c618b9793 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
> @@ -499,11 +499,11 @@ static int px30_lvds_probe(struct platform_device *pdev,
> if (IS_ERR(lvds->dphy))
> return PTR_ERR(lvds->dphy);
>
> - phy_init(lvds->dphy);
> + ret = phy_init(lvds->dphy);
> if (ret)
> return ret;
>
> - phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
> + ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
> if (ret)
> return ret;
>
I thought I (or Heiko) already sent a patch for that but apparently
not...
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Thanks,
Miquèl
