Re: [PATCH] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Xin Xiong <xiongx18@xxxxxxxxxxxx>, Xiyu Yang <xiyuyang19@xxxxxxxxxxxx>, Xin Tan <tanxin.ctf@xxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Wed, 29 Jul 2020 20:36:32 +0200
Cc: kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alexei Starovoitov <ast@xxxxxxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Martin KaFai Lau <kafai@xxxxxx>, Saeed Mahameed <saeedm@xxxxxxxxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, Yuan Zhang <yuanxzhang@xxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

…
> The refcount leak issues take place in two error handling paths.

Can an other wording be a bit nicer for the commit message?


> Fix the issue by …

I suggest to replace this wording by the tag “Fixes”.

Regards,
Markus

Prev by Date: Re: [PATCH -next] drm: xlnx: Fix typo in parameter description
Next by Date: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create
Previous by thread: Re: [PATCH V2] dmaengine: bcm-sba-raid: add missing put_device() call in sba_probe()
Next by thread: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]