On Mon, 2020-07-27 at 16:34 +0000, Frank van der Linden wrote:
> Hi Dan,
>
> On Mon, Jul 27, 2020 at 02:23:44PM +0300, Dan Carpenter wrote:
> >
> > This should return -ENOMEM on failure instead of success.
> >
> > Fixes: 95ad37f90c33 ("NFSv4.2: add client side xattr caching.")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > ---
> > fs/nfs/nfs42xattr.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/nfs/nfs42xattr.c b/fs/nfs/nfs42xattr.c
> > index 23fdab977a2a..e75c4bb70266 100644
> > --- a/fs/nfs/nfs42xattr.c
> > +++ b/fs/nfs/nfs42xattr.c
> > @@ -1040,8 +1040,10 @@ int __init nfs4_xattr_cache_init(void)
> > goto out2;
> >
> > nfs4_xattr_cache_wq = alloc_workqueue("nfs4_xattr",
> > WQ_MEM_RECLAIM, 0);
> > - if (nfs4_xattr_cache_wq == NULL)
> > + if (nfs4_xattr_cache_wq == NULL) {
> > + ret = -ENOMEM;
> > goto out1;
> > + }
> >
> > ret = register_shrinker(&nfs4_xattr_cache_shrinker);
> > if (ret)
> > --
> > 2.27.0
> >
>
> Thanks for catching that one. Since this is against linux-next via
> Trond,
> I assume Trond will add it to his tree (right?)
>
> In any case:
>
>
> Reviewed-by: Frank van der Linden <fllinden@xxxxxxxxxx>
>
>
> - Frank
Frank, why do we need a workqueue here at all?
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx
