Well, since BIT is a linux macro only, we can't use it in ACPICA, because the code is compiler/environment independent. Bob -----Original Message----- From: Garrit Franke <garritfranke@xxxxxxxxx> Sent: Friday, July 24, 2020 9:48 AM To: Moore, Robert <robert.moore@xxxxxxxxx> Cc: Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>; lenb@xxxxxxxxxx; trivial@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx Subject: Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro On Fri, 24 Jul 2020 16:29:14 +0000 "Moore, Robert" <robert.moore@xxxxxxxxx> wrote: > Where is "BIT" defined? It is defined in multiple places (see include/vdso/bits.h for example), therefore I blatently assumed that it would be defined. I'm quite new to kernel development, and I'm learning along the way. Thank you for pointing this out. Would it make sense to copy this file to this drivers root, or is it not worth the effort? Thanks for your time Garrit
