Hello Colin, > -----Original Message----- > From: Colin King <colin.king@xxxxxxxxxxxxx> > Sent: 20 July 2020 22:00 > To: Kishon Vijay Abraham I <kishon@xxxxxx>; Vinod Koul <vkoul@xxxxxxxxxx>; > Seungwon Jeon <essuuj@xxxxxxxxx>; Kiwoong Kim > <kwmad.kim@xxxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call > for rx1_symbol_clk > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The check to see if the call to devm_clk_get on rx1_symbol_clk is checking the > wrong variable, this looks like a copy-paste error. Fix this to check > phy->rx1_symbol instead of phy->rx0_symbol. > This fix is already posted by Gustavo [1] [1] https://lkml.org/lkml/2020/7/20/617 Thanks! > Addresses-Coverity: ("Copy-paste error") > Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/phy/samsung/phy-samsung-ufs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c > b/drivers/phy/samsung/phy-samsung-ufs.c > index 43ef77d1d96c..9832599a0283 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.c > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > @@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct > samsung_ufs_phy *phy) > } > > phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk"); > - if (IS_ERR(phy->rx0_symbol_clk)) { > + if (IS_ERR(phy->rx1_symbol_clk)) { > dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n"); > return PTR_ERR(phy->rx1_symbol_clk); > } > -- > 2.27.0
