Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init_service()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wang Yufen <wangyufen@xxxxxxxxxx>, brcm80211-dev-list@xxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init_service()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 20 Jul 2020 13:07:53 +0200
Cc: kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Franky Lin <franky.lin@xxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxxxxxx>, Wright Feng <wright.feng@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

> When qmi_add_lookup fail, we should destroy the workqueue

Can the following wording variant be nicer for the change description?

   Destroy the work queue object in an if branch
   after a call of the function “qmi_add_lookup” failed.

Regards,
Markus

Prev by Date: [PATCH][next] initrd: fix spelling mistake "depreated" -> "deprecated"
Next by Date: Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()
Previous by thread: [PATCH][next] initrd: fix spelling mistake "depreated" -> "deprecated"
Next by thread: Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux