On 14/07/2020 19:08, Dan Carpenter wrote: > On Tue, Jul 14, 2020 at 06:15:22PM +0100, Chris Wilson wrote: >> Quoting Lionel Landwerlin (2020-07-14 15:39:21) >>> On 14/07/2020 17:36, Dan Carpenter wrote: >>>> The error code needs to be set on this path. It currently returns >>>> success. >>>> >>>> Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait") >>>> Reported-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> >>>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >>>> --- >>>> v2: Fix a different bug instead. :P Colin fixed mine already. >> >> I was thinking that Colin already sent the patch for this one... > > Colin sent a fix for my v1 bug. commit d2921096e707 ("drm/i915/selftest: > fix an error return path where err is not being set") but I don't think > he fixed this one. Yep, coverity didn't pick the other issue up for some reason. > > regards, > dan carpenter >