On 03/07/2020 6.09, Wei Yongjun wrote: > Add the missing unlock before return from function j721e_audio_hw_params() > in the error handling case. I'm not sure how that return made it in there in the first place.. Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > Fixes: 6748d0559059 ("ASoC: ti: Add custom machine driver for j721e EVM (CPB and IVI)") > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- > sound/soc/ti/j721e-evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c > index 3a2a8b1f3aa3..174306cf53ad 100644 > --- a/sound/soc/ti/j721e-evm.c > +++ b/sound/soc/ti/j721e-evm.c > @@ -330,7 +330,7 @@ static int j721e_audio_hw_params(struct snd_pcm_substream *substream, > ret = snd_soc_dai_set_tdm_slot(codec_dai, 0x3, 0x3, 2, > slot_width); > if (ret && ret != -ENOTSUPP) > - return ret; > + goto out; > } > > ret = j721e_configure_refclk(priv, domain_id, params_rate(params)); > > > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki