> In the header.c file, some functions allocate memory after using > do_read_string, but the corresponding memory is not released after > subsequent processing errors, causing memory leaks. I suggest to choose an imperative wording for this change description. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=cd77006e01b3198c75fb7819b3d0ff89709539bb#n151 … > +++ b/tools/perf/util/header.c > @@ -2307,8 +2307,10 @@ static int process_cpu_topology(struct feat_fd *ff, void *data __maybe_unused) > goto error; > > /* include a NULL character at the end */ > - if (strbuf_add(&sb, str, strlen(str) + 1) < 0) > + if (strbuf_add(&sb, str, strlen(str) + 1) < 0) { > + free(str); > goto error; > + } > size += string_size(str); … I propose to add the jump target “free_str” for nicer exception handling in this function implementation. Regards, Markus
