Re: [PATCH v4 04/14] irqchip/davinci-aintc: Fix potential resource leaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/01/2020 04:15 PM, Markus Elfring wrote:
+++ b/drivers/irqchip/irq-davinci-aintc.c
@@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
  				     resource_size(&config->reg));
  	if (!davinci_aintc_base) {
  		pr_err("%s: unable to ioremap register range\n", __func__);
-		return;
+		goto err_release;
  	}
…

Can it help to return any error codes?
Would you like to reconsider the function return type?

No, the initial aim of this patch is just to fix the potential resource leaks,
so I think maybe no need to consider the function return type now.


Regards,
Markus




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux