> On Jun 19, 2020, at 9:30 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> This code doesn't make sense unless the correct "fcport" was found.
>
> Fixes: 9dd9686b1419 ("scsi: qla2xxx: Add changes for devloss timeout in driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> This is from static analysis and review. I'm not super familiar with
> the code and I can't test it. Please review it extra carefully.
>
> drivers/scsi/qla2xxx/qla_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 4576d3ae9937..2436a17f5cd9 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -5944,7 +5944,7 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha)
> break;
> }
>
> - if (NVME_TARGET(vha->hw, fcport)) {
> + if (found && NVME_TARGET(vha->hw, fcport)) {
> if (fcport->disc_state == DSC_DELETE_PEND) {
> qla2x00_set_fcport_disc_state(fcport, DSC_GNL);
> vha->fcport_count--;
> --
> 2.27.0
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
