On Thu, Jun 25, 2020 at 11:05 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Wed, Jun 24, 2020 at 03:41:05PM +0200, Rafael J. Wysocki wrote: > > On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > > > The "tick" variable isn't initialized if "lapic_timer_always_reliable" > > > is true. > > > > If lapic_timer_always_reliable is true, then > > static_cpu_has(X86_FEATURE_ARAT) must also be true AFAICS. > > > > So the lapic_timer_always_reliable check in there looks redundant. > > Can the lapic_timer_always_reliable variable just be removed entirely > and replaced with an static_cpu_has(X86_FEATURE_ARAT) check? Yes, it can. See https://patchwork.kernel.org/patch/11623309/ Thanks!
