> There exists potential resource leaks in the error path, fix them. Would you like to reconsider this change description? https://lore.kernel.org/linux-mips/be3acb13-2963-ddf1-a867-7e30fd23a0b4@xxxxxxxxxxx/ https://lkml.org/lkml/2020/6/24/498 … > +++ b/drivers/irqchip/irq-davinci-aintc.c … > @@ -160,4 +160,13 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config) > irq_base + irq_off, 32); > > set_handle_irq(davinci_aintc_handle_irq); > + > +err_domain_remove: … Are you sure that you would to like to release the allocated system resources always in this function implementation? Otherwise, I suggest to add a return statement before the source code section for the desired exception handling. Regards, Markus