>>> This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN) Can an additional imperative wording be helpful for the change description (besides an adjusted patch subject)? >>> FIXES: c94082656dac7(x86: Use enum instead of literals for trap values) >> >> Is the following tag specification more appropriate? >> >> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values") > Your description looks like more appropriate, thank you. Thanks for your positive feedback. > But I want to receive suggestions from other reviewers also. So I will > send V2 patch as your point once got confirmed. Sorry. Should the confirmation be sufficient from the available software documentation? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 I am curious if this patch review will clarify more aspects. Regards, Markus