> There is a typo in rule r2. Position p1 should be attached to kzalloc() call. I find such a suggestion reasonable for an implementation detail. I would find an other patch subject clearer. How do you think about to move the specification “@p1” out of SmPL disjunctions? Regards, Markus