> in macb_mdio_write, … * Will a desire evolve to improve also this commit message? * Will the tag “Fixes” become helpful? … > +++ b/drivers/net/ethernet/cadence/macb_main.c … > @@ -3840,11 +3842,14 @@ static int at91ether_open(struct net_device *dev) > > ret = macb_phylink_connect(lp); > if (ret) > - return ret; > + goto out; > > netif_start_queue(dev); > > return 0; > +out: > + pm_runtime_put(&lp->pdev->dev); > + return ret; > } … Perhaps use the label “put_runtime” instead? Regards, Markus
