Re: [PATCH] coresight: cti: Fix error handling in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Walter Harms <wharms@xxxxxx>
Subject: Re: [PATCH] coresight: cti: Fix error handling in probe
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 12 Jun 2020 20:38:38 +0300
Cc: Mike Leach <mike.leach@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Suzuki K Poulose <suzuki.poulose@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <6c59bdbc15714b089d256ad50aee58cb@bfs.de>
References: <20200612121047.GF4282@kadam> <20200612121133.GA1139533@mwanda> <6c59bdbc15714b089d256ad50aee58cb@bfs.de>
User-agent: Mutt/1.9.4 (2018-02-28)

On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote:
> Hi Dan,
> 
> nit picking in cti_pm_release()
> 
> IMHO this should be done in 2 steps:
>       if (--nr_cti_cpu == 0)
> ->
>   --nr_cti_cpu ;
>  if ( nr_cti_cpu == 0)

The first way is sort of the more canonical way to write it...  By far.

regards,
carpenter

References:
- [PATCH] coresight: cti: Fix error handling in probe
  - From: Dan Carpenter
- AW: [PATCH] coresight: cti: Fix error handling in probe
  - From: Walter Harms

Prev by Date: Re: [PATCH] coresight: cti: Fix error handling in probe
Next by Date: Re: [v2] proc/fd: Remove unnecessary variable initialisations in seq_show()
Previous by thread: AW: [PATCH] coresight: cti: Fix error handling in probe
Next by thread: Re: [PATCH] coresight: cti: Fix error handling in probe
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]