> Am 10.06.2020 um 10:59 schrieb Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > > Smatch complains that "rc" can be uninitialized if we hit the "break;" > statement on the first iteration through the loop. I suspect that this > can't happen in real life, but returning a zero literal is cleaner and > silence the static checker warning. > Right, it‘s impossible in real life. Thanks! Acked-by: David Hildenbrand <david@xxxxxxxxxx> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/virtio/virtio_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index f658fe9149beb..893ef18060a02 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -1192,7 +1192,7 @@ static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id, > VIRTIO_MEM_MB_STATE_OFFLINE); > } > > - return rc; > + return 0; > } > > /* > -- > 2.26.2 >
