On 2020-06-03 8:53 PM, Dan Carpenter wrote:
> The error handling dereferences "vport". There is nothing we can do if
> it is an error pointer except returning the error code.
>
> Fixes: 133dcfc577ea ("net/mlx5: E-Switch, Alloc and free unique metadata for match")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
> index 4e55d7225a265..857f6193f3b14 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
> @@ -301,8 +301,7 @@ int mlx5_esw_acl_ingress_vport_bond_update(struct mlx5_eswitch *esw, u16 vport_n
>
> if (WARN_ON_ONCE(IS_ERR(vport))) {
> esw_warn(esw->dev, "vport(%d) invalid!\n", vport_num);
> - err = PTR_ERR(vport);
> - goto out;
> + return PTR_ERR(vport);
> }
>
> esw_acl_ingress_ofld_rules_destroy(esw, vport);
>
thanks!
Reviewed-by: Roi Dayan <roid@xxxxxxxxxxxx>
