On Wed, Jun 03, 2020 at 04:21:51PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Currently the assignment of -ENOMEM to error is redudant because error > is not being read and -ENOMEM is being hard coded as an error return. > Fix this by returning the error code in variable 'error'; this also > allows the error code from a failed call to input_register_device to > be preserved and returned to the caller rather than just returning > a possibly inappropriate -ENOMEM. > > Kudos to Dan Carpenter for the suggestion of an improved fix. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Thanks! Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter