> in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed, > put_device() is missing in the error handling patch. How do you think about another wording variant? A coccicheck run provided information like the following. drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device; call of_find_device_by_node on line 792, but without a corresponding object release within this function. Generated by: scripts/coccinelle/free/put_device.cocci Thus add a jump target to fix the exception handling for this function implementation. Would you like to add the tag “Fixes” to the commit message? Regards, Markus
