Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Zhang, Qiang" <Qiang.Zhang@xxxxxxxxxxxxx>
Subject: Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 28 May 2020 12:57:03 +0300
Cc: Markus Elfring <markus.elfring@xxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Lai Jiangshan <jiangshanlai@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <DM6PR11MB3257D6E7E93A518392502809FF8E0@DM6PR11MB3257.namprd11.prod.outlook.com>
References: <20200527075715.36849-1-qiang.zhang@windriver.com> <284c7851-4e89-a00f-a2e6-aa8e2e1f3fce@web.de> <DM6PR11MB32573F3884A864ECD586235EFF8E0@DM6PR11MB3257.namprd11.prod.outlook.com> <DM6PR11MB3257D6E7E93A518392502809FF8E0@DM6PR11MB3257.namprd11.prod.outlook.com>
User-agent: Mutt/1.9.4 (2018-02-28)

Guys, the patch is wrong.  The kfree is harmless when this is called
from destroy_workqueue() and required when it's called from
pwq_unbound_release_workfn().  Lai Jiangshan already explained this
already.  Why are we still discussing this?

regards,
dan carpenter

Follow-Ups:
- Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
  - From: Lai Jiangshan
- Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
  - From: Tejun Heo

References:
- Re: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
  - From: Markus Elfring
- 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
  - From: Zhang, Qiang

Prev by Date: Re: [PATCH v6] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
Next by Date: Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
Previous by thread: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
Next by thread: Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]