Am Montag, den 18.05.2020, 14:29 +0300 schrieb Dan Carpenter:
> If the mapping address is wrong then we have to release the reference to
> it before returning -EINVAL.
>
> Fixes: 088880ddc0b2 ("drm/etnaviv: implement softpin")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Thanks, applied to etnaviv/fixes.
Regards,
Lucas
> ---
> From static analysis. Untested.
>
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> index 3b0afa156d92..54def341c1db 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
> @@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit)
> }
>
> if ((submit->flags & ETNA_SUBMIT_SOFTPIN) &&
> - submit->bos[i].va != mapping->iova)
> + submit->bos[i].va != mapping->iova) {
> + etnaviv_gem_mapping_unreference(mapping);
> return -EINVAL;
> + }
>
> atomic_inc(&etnaviv_obj->gpu_active);
>
