… > new_blkg = blkg_alloc(pos, q, GFP_KERNEL); … I suggest to omit the source code quotation from the change description. > if calling blkg_lookup_check() failed, at the IS_ERR block, > the new_blkg should be free before goto lable fail_unlock > in blkg_conf_prep() function. How do you think about a wording variant like the following? If a call of the function “blkg_lookup_check” failed, release the previously allocated block group before jumping to the target “fail_unlock” in the implementation of the function “blkg_conf_prep”. Would you like to add the tag “Fixes” to the commit message? Regards, Markus
