Hi all, On Tue, 12 May 2020 at 12:49, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Tue, Apr 28, 2020 at 4:13 PM Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote: > > > In case of error, the function of_drm_find_bridge() returns NULL pointer > > not ERR_PTR(). The IS_ERR() test in the return value check should be > > replaced with NULL test. > > > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > Patch applied! Thanks Wei, sorry for the long delay. > It would be nice if of_drm_find_bridge and of_drm_find_panel were consistent - either return NULL or an ERR_PTR. Otherwise the next person using them is likely to get it wrong. -Emil
