Re: [PATCH net-next v2] net: ethernet: ti: fix some return value check of cpsw_ale_create()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 8 May 2020 14:26:27 +0300 Grygorii Strashko wrote:
> On 08/05/2020 13:06, Wei Yongjun wrote:
> > cpsw_ale_create() can return both NULL and PTR_ERR(), but all of
> > the caller only check NULL for error handling. This patch convert
> > it to only return PTR_ERR() in all error cases, all the caller using
> > IS_ERR() install of NULL test.
> > 
> > Also fix a return negative error code from the cpsw_ale_create()
> > error handling case instead of 0 in am65_cpsw_nuss_probe().
> > 
> > Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
> > Fixes: 4b41d3436796 ("net: ethernet: ti: cpsw: allow untagged traffic on host port")  
> 
> ^ I do not think it can be back-ported so far back.
> So, or drop second "Fixes: 4b41d3436796"
> or split am65-cpsw-nuss.c changes

Please also tag this commit with [net] not [net-next], 
AFAICS the problem is present in Linus's tree.



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux