Hi Julia, > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate > that the list elements have type spu_context, not spu as used here. Change > the type of tmp accordingly. Looks good to me; we could even use ctx there, rather than the separate tmp variable. Reviewed-by: Jeremy Kerr <jk@xxxxxxxxxx> Cheers, Jeremy