>> I hope that other contributors can convince you to improve also this >> commit message considerably. >> Would you like to fix the spelling besides other wording weaknesses? > > How about this wording: > > Commit d7a5502b0bb8b ("net: broadcom: convert to > devm_platform_ioremap_resource_byname()") > inadvertently made idm_base and nicpm_base mandatory. These are > optional properties. > probe will fail when they're not defined. The commit is partially > reverted so that they are > obtained by platform_get_resource_byname() as before. amac_base can > still be obtained > by devm_platform_ioremap_resource_byname(). Is it interesting anyhow that another attempt for such an improvement did not get the possibly desired software development attention? https://lore.kernel.org/lkml/20200505.111206.118627398774406136.davem@xxxxxxxxxxxxx/ https://lore.kernel.org/patchwork/comment/1430759/ https://lkml.org/lkml/2020/5/5/1114 Regards, Markus