Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Wed, 6 May 2020 17:30:06 +0200
Cc: kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Hartmut Knaack <knaack.h@xxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.

Is there a need to prevent similar function calls by the means of
advanced source code analysis?

Regards,
Markus

Follow-Ups:
- Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
  - From: Jonathan Cameron

Prev by Date: Re: [PATCH] i2c: puv3: Fix an error handling path in puv3_i2c_probe()
Next by Date: Re: MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM
Previous by thread: Re: [PATCH] i2c: puv3: Fix an error handling path in puv3_i2c_probe()
Next by thread: Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux