On Fri, May 01, 2020 at 10:40:20AM -0500, Richard Gong wrote: > Hi, > > On 4/29/20 1:52 AM, Christophe JAILLET wrote: > > Replace 'devm_kmalloc_array(... | __GFP_ZERO)' with the equivalent and > > shorter 'devm_kcalloc(...)'. > > > It doesn't make much sense. > Actually devm_kcalloc returns devm_kmalloc_array(.., flag | __GFP_ZERO). > devm_kcalloc() is better style and easier to read. I was just reading a bunch of AMD code that does this and I almost complained to them that devm_kmalloc_array() doesn't zero the memory so they were freeing uninitialized pointers. regards, dan carpenter
