On Mon, May 04, 2020 at 09:41:21PM +0200, Christophe JAILLET wrote: > - in your example, before commit f52c380a48f52, it was allocated with > kmalloc, so it was maybe to avoid a really unlikely '__list_add_valid' > failure. Now that it is kzalloc'ed, this can not happen anymore. No, it was never possible to get a __list_add_valid() failure. The list you're adding to has to be initialized, but the list item that doesn't. In __list_add_valid() the "new" is "&entry_obj->list" which is an offset into the entry_obj object. regards, dan carpenter