On Sun, May 03, 2020 at 11:10:01PM +0200, Julia Lawall wrote: > Hello, > > I was wondering what is the point of code like the following: > > INIT_LIST_HEAD(&bb->list); > list_add(&bb->list, &s->workload->shadow_bb); > > As far as I can see, list_add will initialize both fields of the list_head > structure without looking at their values, so why is the INIT_LIST_HEAD > needed? Yeah. You're right. It's not needed. regards, dan carpenter