On Tue, Apr 28, 2020 at 12:52:59PM +0200, Markus Elfring wrote: > > And there is no 'Fixes:' tag format checker in checkpatch > > I have taken another look at corresponding implementation details. > Will programming challenges get any more attention? > > > > to check the commit id length too, > > The mentioned script contains the following information. > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/scripts/checkpatch.pl?id=b240f960afb900e59112ebcfa5a759bb0a85a14e#n2818 > > # Check for git id commit length and improperly formed commit descriptions > > > > so let's add dedicated checker to check these conditions for 'Fixes:' tag. > > How do you think about to reconsider the usage of the word “checker” > at specific places? Yes, I will use the word "check" only in later version. > > > > + my $id = '0123456789ab'; > > + my $orig_desc = "commit description"; > > * Do you try to extend the existing software analysis approach “GIT_COMMIT_ID”? > > * Would you like to avoid the development of duplicate Perl code? Fixes: lines don't need to have a "commit" prefix before the commit id, the description in normal commit id could across multiple lines, and we don't need to consider the $commit_log_possible_stack_dump for 'Fixes:' tag line. I mean it will make the GIT_COMMIT_ID code become harder to read and maintain. > > Regards, > Markus
