On 28/04/2020 06:25, weiyongjun (A) wrote:
On 4/27/20 4:40 AM, Wei Yongjun wrote:
platform_get_resource() may fail and return NULL, so we should better
check it's return value to avoid a NULL pointer dereference a bit
later in the code.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2; @@
res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
---
Could we use devm_platform_ioremap_resource() instead?
We cannot use devm_platform_ioremap_resource() here, see
Commit 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
Correct, could you add fixed tag as above commit actually introduced an issue:
devm_ioremap_resource() checks input parameters for null.
Reviewed-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
--
Best regards,
grygorii
