From: Colin Ian King <colin.king@xxxxxxxxxxxxx> Currently the memory allocation failure check for ret->path is checking that ret is null rather than ret->path. Fix this by checking ret->path instead. Addresses-Coverity: ("Dereference null return") Fixes: bd8bdc532152 ("btrfs: backref: introduce the skeleton of btrfs_backref_iter") Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- fs/btrfs/backref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 60a69f7c0b36..78e6c9a64212 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -2307,7 +2307,7 @@ struct btrfs_backref_iter *btrfs_backref_iter_alloc( return NULL; ret->path = btrfs_alloc_path(); - if (!ret) { + if (!ret->path) { kfree(ret); return NULL; } -- 2.25.1