Re: [PATCH] tee: remove unnecessary NULL check in tee_shm_alloc()

Jens Wiklander <jens.wiklander@xxxxxxxxxx> · Mon, 20 Apr 2020 13:13:13 +0200

On Tue, Apr 7, 2020 at 11:32 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Smatch complains that "ctx" isn't checked consistently:
>
>     drivers/tee/tee_shm.c:164 tee_shm_alloc()
>     warn: variable dereferenced before check 'ctx' (see line 95)
>
> I audited the callers and "ctx" can't be NULL so the check can be
> removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>  drivers/tee/tee_shm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, I'm picking this up.

Cheers,
Jens