On Mon, Apr 06, 2020 at 07:48:52PM +0200, Christophe JAILLET wrote:
> Nevertheless, I wrote another script (see below), which triggers ~2800 times
> in ./drivers only.
> Some are false positives, but most look valid.
I did a quick grep and you're right there are a ton of these!
>
> Not sure that fixing this kind of stuff really make sense.
>
> A better approach could be to teach ./checkpatch.pl, but I don't have the
> knowledge for that.
Yeah. I think so too. Here is what I tried. $logFunctions ends up
catching too many functions like process_mcheck_info() so maybe we need
a stricter regex for that.
regards,
dan carpenter
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d64c67b67e3c..1bcfa9e18059 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5493,6 +5493,13 @@ sub process {
"Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . $herecurr);
}
+# check for missing newline
+ if ($line =~ /\t$logFunctions\b.*$String[,)]/ && $rawline !~ /\\n/ &&
+ $rawline !~ / "[,)]/ &&
+ $line !~ /debugfs_/ && $line !~ /MODULE_/) {
+ WARN("MISSING_NEWLINE", "Missing newline?\n" . $herecurr);
+ }
+
# Check for user-visible strings broken across lines, which breaks the ability
# to grep for the string. Make exceptions when the previous string ends in a
# newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
