Re: [PATCH] qtnfmac: Simplify code in _attach functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Subject: Re: [PATCH] qtnfmac: Simplify code in _attach functions
From: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx>
Date: Tue, 7 Apr 2020 22:48:13 +0300
Cc: imitsyanko@xxxxxxxxxxxxx, avinashp@xxxxxxxxxxxxx, smatyukevich@xxxxxxxxxxxxx, kvalo@xxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, huangfq.daxian@xxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20200407193233.9439-1-christophe.jaillet@wanadoo.fr>
Mail-followup-to: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, imitsyanko@xxxxxxxxxxxxx, avinashp@xxxxxxxxxxxxx, smatyukevich@xxxxxxxxxxxxx, kvalo@xxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, huangfq.daxian@xxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
References: <20200407193233.9439-1-christophe.jaillet@wanadoo.fr>
User-agent: NeoMutt/20170113 (1.7.2)

Hello Christophe,

> There is no need to re-implement 'netdev_alloc_skb_ip_align()' here.
> Keep the code simple.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Thanks for cleaning this up!

Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx>

Regards,
Sergey

References:
- [PATCH] qtnfmac: Simplify code in _attach functions
  - From: Christophe JAILLET

Prev by Date: [PATCH] qtnfmac: Simplify code in _attach functions
Next by Date: Re: [PATCH] gpu/drm: ingenic: Delete an error message in ingenic_drm_probe()
Previous by thread: [PATCH] qtnfmac: Simplify code in _attach functions
Next by thread: Re: [PATCH] qtnfmac: Simplify code in _attach functions
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]