Re: [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-04-07 at 21:00 +0200, Christophe JAILLET wrote:
> Here, we look for function such as 'netdev_alloc_skb_ip_align', so a '_'
> is missing in the regex.
> 
> To make sure:
>    grep -r --include=*.c skbip_a * | wc   ==>   0 results
>    grep -r --include=*.c skb_ip_a * | wc  ==> 112 results

Acked-by: Joe Perches <joe@xxxxxxxxxxx>

> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 529c892722b9..c392ab8ea12e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -479,7 +479,7 @@ our $allocFunctions = qr{(?x:
>  		(?:kv|k|v)[czm]alloc(?:_node|_array)? |
>  		kstrdup(?:_const)? |
>  		kmemdup(?:_nul)?) |
> -	(?:\w+)?alloc_skb(?:ip_align)? |
> +	(?:\w+)?alloc_skb(?:_ip_align)? |
>  				# dev_alloc_skb/netdev_alloc_skb, et al
>  	dma_alloc_coherent
>  )};




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux