[bug report] bus: mhi: core: Add support for data transfer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Manivannan Sadhasivam,

The patch 189ff97cca53: "bus: mhi: core: Add support for data
transfer" from Feb 20, 2020, leads to the following static checker
warning:

	drivers/bus/mhi/core/main.c:1093 mhi_gen_tre()
	warn: bitwise AND condition is false here

drivers/bus/mhi/core/main.c
  1088  
  1089          ret = mhi_cntrl->map_single(mhi_cntrl, buf_info);
  1090          if (ret)
  1091                  return ret;
  1092  
  1093          eob = !!(flags & MHI_EOB);
                                 ^^^^^^^
This is zero.  Was BIT(0) intended?

  1094          eot = !!(flags & MHI_EOT);
  1095          chain = !!(flags & MHI_CHAIN);
  1096          bei = !!(mhi_chan->intmod);
  1097  
  1098          mhi_tre = tre_ring->wp;
  1099          mhi_tre->ptr = MHI_TRE_DATA_PTR(buf_info->p_addr);

regards,
dan carpenter



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux