>> ssp->irq = platform_get_irq(pdev, 0); >> - if (ssp->irq < 0) { >> - dev_err(dev, "no IRQ resource defined\n"); >> + if (ssp->irq < 0) >> return -ENODEV; >> - } > > At the same time we can unshadow the error code, i.e. > return ssp->irq; Have you got any preferences for the order of possible change combinations? Regards, Markus