Re: [PATCH v6] crypto: amlogic - Delete duplicate dev_err() in meson_crypto_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> When something goes wrong, platform_get_irq() will print an error message,

This information is reasonable.


> so in order to avoid the situation of repeat output,

Possible adjustments:
* Separate sentences

* Avoid another typo: “repeated output”


> we should remove dev_err here.

Thus remove a redundant function call.
(An imperative wording is usually preferred for Linux commit messages.)

Regards,
Markus




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux