On Thu, Apr 02, 2020 at 02:14:41PM +0100, Colin King wrote: > @@ -1979,9 +1984,9 @@ static int ds1307_probe(struct i2c_client *client, > > ds1307_hwmon_register(ds1307); > ds1307_clks_register(ds1307); > - ds1307_wdt_register(ds1307); > + err = ds1307_wdt_register(ds1307); > > - return 0; > + return err; > > exit: > return err; This bit is weird. I guess just delete the "return 0;" without introducing a new "return err;". regards, dan carpenter