Thanks Colin, We also found this typo recently, but you were ahead of us ) > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > rec->llc is currently being assigned twice, once with the lower 8 bits > from packed_record[8] and then re-assigned afterwards with data from packed_record[9]. This looks like a type, > I believe the second assignment should be using the |= operator rather than a direct assignment. > Addresses-Coverity: ("Unused value") > Fixes: b8f8a0b7b5cb ("net: atlantic: MACSec ingress offload HW bindings") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Acked-by: Igor Russkikh <irusskikh@xxxxxxxxxx>